Make truncspace explanation more specific#284
Conversation
|
|
||
| * `truncspace(W)`: truncates such that the dimension of the internal vector space is | ||
| smaller than that of `W` in any sector, i.e. with | ||
| smaller than or equal to that of `W` in any sector, i.e. with |
There was a problem hiding this comment.
| smaller than or equal to that of `W` in any sector, i.e. with | |
| no bigger than that of `W` in any sector, i.e. with |
also possible
There was a problem hiding this comment.
In that case I would go for 'no larger than', but other than that it's the same to me.
There was a problem hiding this comment.
Or 'not greater than', or 'not higher than'. I now also start to wonder about the formality of 'no' versus 'not.
It seems Julia docs describes <= and >= "Less-than-or-equals" and "greater-than-or-equals".
I also find online that 'larger' sometimes refers to the absolute value, but since dimensions are positive that is still valid. The mysteries of the English language ...
There was a problem hiding this comment.
I went with 'no greater than'. I think 'greater' is the most appropriate one in the end, but I do think 'no' fits better than 'not' in this kind of phrase.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
leburgel
force-pushed
the
lb/truncpace_docstring
branch
from
fda00f8 to
a957b65
Compare
|
I don't think we need CI to finish for this. |
3 participants
I managed to confuse myself about the intended behavior of the
truncspacetruncation scheme since dimensions were coming out smaller than I expected, and the explanation in thetsvddocstring didn't really help. It turned out that the truncation did behave as I would expect, but then the docstring is technically incorrect and a bit confusing.So, I thought it would be better to make this a bit more specific.